✨ [#4420] Validation for fields within AddressNL component #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
7 times, most recently
from
a47cf07 to
5f1d2e7
Compare
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
3 times, most recently
from
e7194c1 to
78c9ade
Compare
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
2 times, most recently
from
76a1ac6 to
d7bf6b2
Compare
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
d7bf6b2 to
bb41eb4
Compare
sergei-maertens
requested changes
Aug 13, 2024
sergei-maertens
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
bb41eb4 to
b064b40
Compare
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
d6feb8a to
01713f8
Compare
stevenbal
commented
Aug 19, 2024
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
01713f8 to
91f9da5
Compare
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
cee83da to
4027f66
Compare
Comment on lines
93
to
95
| const patternInput = canvas.getByLabelText( | ||
| 'Regular expression for postcode' | ||
| ) as HTMLInputElement; |
There was a problem hiding this comment.
the as casting should not be needed, often you can pass the expected type as a generic param: getByLabelText<HTMLInputElement> or if the problem is that it can be null or undefined, you can add an exclamation mark at the end saying that you know it will resolve:
canvas.getByLabelText("some label")!;There was a problem hiding this comment.
I'll pass the generic param, the exclamation mark doesn't work, it gives me the same error as when I don't add the type at all: Property 'value' does not exist on type 'HTMLElement'.ts(2339) (on the line expect(patternInput.value).toBe('Amsterdam');)
sergei-maertens
approved these changes
Aug 19, 2024
stevenbal
force-pushed
the
feature/4420-addressNL-fields-validation
branch
2 times, most recently
from
f3e73a6 to
65e171e
Compare
sergei-maertens
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
65e171e to
a431899
Compare
the following components can now be validated using regex: * postcode * city
* Use stricter types for the SubComponentValidation react component prop - not any string is accepted, it must be one of the two union members defined in the type * pass the correct validation schema to 'useManageValidatorsTranslations', using the subcomponent schemas defined in the type
* use prefix for AddressNL SubcomponentValidation and useManageValidatorsTranslations * remove unnecessary waitFor blocks in AddressNL stories * add aria-label to datamap
by replacing getByLabelText with findByLabelText after userEvent.click(...)
sergei-maertens
force-pushed
the
feature/4420-addressNL-fields-validation
branch
from
78af523 to
d540808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially closes open-formulieren/open-forms#4420
Requires open-formulieren/types#51 to be merged and released first